drowl87/hextra_mirror
1
0
Fork 1
mirror of https://github.com/imfing/hextra.git synced 2025-08-23 19:56:38 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(toc): improve handling of heading IDs by decoding and normalizing for hash navigation (#757)

Browse Source
This commit is contained in:
Xin
2025-08-16 00:37:45 +08:00
committed by GitHub
parent de97b0ec16
commit f79bd1a8cf
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
assets/js/toc-scroll.js
View File

@@ -16,7 +16,7 @@ document.addEventListener("DOMContentLoaded", function () {
const headingIds = Array.from(tocLinks).map((link) => link.getAttribute("href").substring(1)); const headingIds = Array.from(tocLinks).map((link) => link.getAttribute("href").substring(1));
const headings = headingIds.map((id) => document.getElementById(id)).filter(Boolean); const headings = headingIds.map((id) => document.getElementById(decodeURIComponent(id))).filter(Boolean);
if (headings.length === 0) return; if (headings.length === 0) return;
let currentActiveLink = null; let currentActiveLink = null;
@@ -39,7 +39,8 @@ document.addEventListener("DOMContentLoaded", function () {
return Math.abs(headingTop) < Math.abs(closestTop) ? heading : closest; return Math.abs(headingTop) < Math.abs(closestTop) ? heading : closest;
}); });
const targetId = topMostHeading.id; // Encode the id and make it lowercase to match the TOC link
const targetId = encodeURIComponent(topMostHeading.id).toLowerCase();
const targetLink = toc.querySelector(`a[href="#${targetId}"]`); const targetLink = toc.querySelector(`a[href="#${targetId}"]`);
if (targetLink && targetLink !== currentActiveLink) { if (targetLink && targetLink !== currentActiveLink) {
@@ -64,7 +65,7 @@ document.addEventListener("DOMContentLoaded", function () {
// Handle direct navigation to page with hash // Handle direct navigation to page with hash
function handleHashNavigation() { function handleHashNavigation() {
const hash = window.location.hash; const hash = window.location.hash; // already url encoded
if (hash) { if (hash) {
const targetLink = toc.querySelector(`a[href="${hash}"]`); const targetLink = toc.querySelector(`a[href="${hash}"]`);
if (targetLink) { if (targetLink) {